Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialization of status list #1423

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

itsyaasir
Copy link
Contributor

Description of change

This PR addresses the serialization issue with the status_list_index field, which was incorrectly serialized in the StatusListEntry2021 type.

Links to any relevant issues

Fixes the wrong index type in the source code; Link here

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@itsyaasir itsyaasir added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Nov 12, 2024
@itsyaasir itsyaasir requested a review from a team as a code owner November 12, 2024 20:46
@itsyaasir itsyaasir requested a review from UMR1352 November 12, 2024 20:46
@itsyaasir
Copy link
Contributor Author

@UMR1352 Correct serialization applied.

@itsyaasir itsyaasir self-assigned this Nov 13, 2024
@itsyaasir itsyaasir merged commit e8df299 into main Nov 13, 2024
14 checks passed
@UMR1352 UMR1352 deleted the fix/serialization-of-status-list branch November 13, 2024 13:22
@eike-hass eike-hass added this to the v1.5 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

4 participants